ofPixels proposal #7929
Open
ofPixels proposal #7929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it will be closed in favor of |
danoli3
reviewed
Jul 11, 2024
| @@ -1368,7 +1371,7 @@ inline typename ofPixels_<PixelType>::ConstPixel ofPixels_<PixelType>::ConstPixe | |||
|
|
|||
| //---------------------------------------------------------------------- | |||
| template<typename PixelType> | |||
| inline ofPixels_<PixelType>::ConstLine::ConstLine(const PixelType * _begin, size_t stride, size_t componentsPerPixel, size_t lineNum, ofPixelFormat pixelFormat) | |||
| inline ofPixels_<PixelType>::ConstLine::ConstLine(const PixelType * _begin, size_t stride, size_t componentsPerPixel, size_t lineNum, ofPixelFormat _pixelFormat) | |||
There was a problem hiding this comment.
to differentiate the function parameter to the private member called pixelFormat;
| return 1 * sizeof(PixelType) * 8; | ||
| static size_t numChannelsFromPixelFormat(ofPixelFormat _pixelFormat) { | ||
| std::unordered_map<ofPixelFormat, size_t> pixelFormatChannels { | ||
| { OF_PIXELS_RGB, 3 }, |
| return | ||
| std::unordered_map<ofPixelFormat, std::string> { | ||
| { OF_PIXELS_GRAY, "OF_PIXELS_GRAY" }, | ||
| { OF_PIXELS_GRAY_ALPHA, "OF_PIXELS_GRAY_ALPHA" }, |
| @@ -1344,30 +1332,41 @@ bool ofPixels_<PixelType>::resizeTo(ofPixels_<PixelType>& dst, ofInterpolationMe | |||
| size_t dstHeight = dst.getHeight(); | |||
| size_t bytesPerPixel = getBytesPerPixel(); | |||
|
|
|||
|
|
|||
| PixelType * dstPixels = dst.getData(); | |||
| auto dstPixels = dst.getData(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplification of pixelbits / bytes, channel count, etc.